linux-kernel - Re: [PATCH 0/7] staging: rtl8188eu: replace driver with better version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <630e139c-85e5-f006-6b64-e368847251fc@lwfinger.net>
Date:   Thu, 22 Jul 2021 20:56:33 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Phillip Potter <phil@...lpotter.co.uk>, gregkh@...uxfoundation.org
Cc:     dan.carpenter@...cle.com, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, fabioaiuto83@...il.com
Subject: Re: [PATCH 0/7] staging: rtl8188eu: replace driver with better
 version

On 7/22/21 7:42 PM, Phillip Potter wrote:
> I had to break this patchset up a bit to get around the file size limits
> on the mailing list, and also I removed the hostapd stuff which is
> userspace related and therefore not required.
> 
> The driver currently in staging is older and less functional than the
> version on Larry Finger's GitHub account, branch v5.2.2.4. This series
> of patches therefore:
> 
> (1) Removes the current driver from staging.
> (2) Imports the GitHub version mentioned above in its place.
> 
> There is plenty of work to do to this driver, including to its Makefile,
> but it is at least buildable/usable for now.
> 
> Phillip Potter (7):
>    staging: rtl8188eu: remove existing staging driver
>    staging: rtl8188eu: introduce new core dir for RTL8188eu driver
>    staging: rtl8188eu: introduce new hal dir for RTL8188eu driver
>    staging: rtl8188eu: introduce new os_dep dir for RTL8188eu driver
>    staging: rtl8188eu: introduce new include dir for RTL8188eu driver
>    staging: rtl8188eu: introduce new supporting files for RTL8188eu
>      driver
>    staging: rtl8188eu: attach newly imported driver to build system

Phillip,

Patch 3/7 fails with a
drivers/staging/rtl8188eu/hal/phydm_precomp.h: already exists in error:
working directory. When I deleted the file, the patch applied.

Patch 5/7 fails with a drivers/staging/rtl8188eu/include/hal_data.h: already 
exists in working directory. Again it applied when I manually deleted that file.

Patches 2-6 all have trailing whitespace warnings.

I have started testing. Unfortunately, my GitHub version has a fault in that it 
runs systemd-udevd at 100% of a CPU. So far, I have found that an older commit 
works fine. As soon as I find the fault, I will let you know.

Larry