linux-kernel - Re: [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YPq1+NzJeqLZVctW@smile.fi.intel.com>
Date:   Fri, 23 Jul 2021 15:28:40 +0300
From:   "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>
To:     Dennis Giaya <dgiaya@...i.edu>
Cc:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>
Subject: Re: [PATCH v1 1/1] serial: max310x: Use clock-names property
 matching to recognize XTAL

On Thu, Jul 22, 2021 at 09:05:13PM +0000, Dennis Giaya wrote:
> Andy,
> 
> I've tested this out on my hardware that uses an external oscillator
> 'osc' (as opposed to external crystal 'xtal').
> 
> With the relevant asl
> 	Package () {"compatible", "maxim,max14830"},
> 	Package ()
> {"clock-frequency", 19200000},
> 	Package () {"clock-names", "osc"},
> 
> Previously, the driver logic would default to 'xtal' and then compare
> against the narrower frequency range and throw an error because 19.2MHz
> was not allowed. With your patch, it proceeds as 'osc' and appears to
> work as intended.

Thanks for testing!
I assume I may convert above to the Tested-by: or equivalent tag.

JFYI, in OSS mailing lists we do not top post.


-- 
With Best Regards,
Andy Shevchenko