linux-kernel - Re: [PATCH 0/2] Check for endpoints in fwnode->secondary more sensibly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPq3HvKWvChRp45A@smile.fi.intel.com>
Date:   Fri, 23 Jul 2021 15:33:34 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Daniel Scally <djrscally@...il.com>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        rafael@...nel.org, laurent.pinchart@...asonboard.com
Subject: Re: [PATCH 0/2] Check for endpoints in fwnode->secondary more
 sensibly

On Thu, Jul 22, 2021 at 09:19:27PM +0100, Daniel Scally wrote:
> Hello all
> 
> A while ago I patched fwnode_graph_get_endpoint_by_id() to check for endpoints
> against fwnode->secondary if none was found against the primary. It's actually
> better to do this in fwnode_graph_get_next_endpoint() instead, since that
> function is called by fwnode_graph_get_endpoint_by_id() and also directly called
> in a bunch of other places (primarily sensor drivers checking that they have
> endpoints connected during probe). This small series just adds the equivalent
> functionality to fwnode_graph_get_next_endpoint() and reverts the earlier
> commit.

Makes sense to me (one nit-pick to patch 1, though).
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Daniel Scally (2):
>   device property: Check fwnode->secondary in
>     fwnode_graph_get_next_endpoint()
>   Revert "media: device property: Call fwnode_graph_get_endpoint_by_id()
>     for fwnode->secondary"
> 
>  drivers/base/property.c | 30 +++++++++++++++++++++---------
>  1 file changed, 21 insertions(+), 9 deletions(-)
> 
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko