linux-kernel - Re: [PATCH] Drivers: comedi: drivers: ni_routing: ni_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPrBiNPdeyTfpkUE@kroah.com>
Date:   Fri, 23 Jul 2021 15:18:00 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Artem Baxtiarov <baxtiarovartem@...il.com>
Cc:     abbotti@....co.uk, hsweeten@...ionengravers.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: comedi: drivers: ni_routing: ni_device_routes:
 pci-6070e.c Lindented

On Fri, Jul 23, 2021 at 03:27:49PM +0300, Artem Baxtiarov wrote:
> I found "Lindent" item in drivers/comedi/TODO.
> I used scripts/Lindent to indent

Please never use that on files.  checkpatch is what you should be using
for this, and odds are the TODO file should just be removed instead.

> drivers/comedi/drivers/ni_routing/ni_device_routes/pci-6070e.c

If you look, your changes make the code harder to read, sorry, but this
isn't needed.

thanks,

greg k-h