linux-kernel - Re: [PATCH v2 1/2] dt-bindings: iio: accel: Add ADXL355 in trivial-devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210723172902.00004151@Huawei.com>
Date:   Fri, 23 Jul 2021 17:29:02 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Puranjay Mohan <puranjay12@...il.com>
CC:     <Michael.Hennerich@...log.com>, <alexandru.ardelean@...log.com>,
        <jic23@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lars@...afoo.de>, <Dragos.Bogdan@...log.com>,
        <Darius.Berghe@...log.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: accel: Add ADXL355 in
 trivial-devices

On Thu, 22 Jul 2021 11:51:53 +0530
Puranjay Mohan <puranjay12@...il.com> wrote:

> Add ADXL355, a 3-Axis MEMS Accelerometer into trivial-devices.yaml.
> 
> Signed-off-by: Puranjay Mohan <puranjay12@...il.com>

Hi Puranjay,

So, a binding should include (as well as we can) all hardware elements,
not just those currently supported by the driver.

This particular device has two interrupts + a dataready signal which is
effectively another interrupt. It also has dual power supplies.

That makes it a rather non-trivial device from the point of view of
bindings. Hence, please give it a file of it's own and also document
the interrupt and supply elements.

Jonathan
 
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 8341e9d23..0097d6e81 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -41,6 +41,8 @@ properties:
>            - adi,adp5589
>              # +/-1C TDM Extended Temp Range I.C
>            - adi,adt7461
> +            # ADXL355:- 3-Axis Low noise MEMS Accelerometer.
> +          - adi,adxl355
>              # +/-1C TDM Extended Temp Range I.C
>            - adt7461
>              # AMS iAQ-Core VOC Sensor