linux-kernel - Re: [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c09e3c193c62a0a85c552ebce85f858883996104.camel@hadess.net>
Date:   Fri, 23 Jul 2021 21:11:11 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Hamza Mahfooz <someguy@...ective-light.com>,
        linux-kernel@...r.kernel.org
Cc:     Filipe Laíns <lains@...eup.net>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY
 property for newer devices

On Fri, 2021-07-23 at 14:57 -0400, Hamza Mahfooz wrote:
> For devices that only support the BATTERY_VOLTAGE (0x1001) feature,
> UPower
> requires the additional information provided by this patch, to set
> them up.
> 
> Signed-off-by: Hamza Mahfooz <someguy@...ective-light.com>
> ---
> 
> v2: use ARRAY_SIZE() and set voltages[]'s size to 100
> 
> v3: add a check to ensure that exactly 100 elements are in voltages[]
> ---

> <snip>
> +       BUILD_BUG_ON(ARRAY_SIZE(voltages) != 100);

Sweet!

Reviewed-By: Bastien Nocera <hadess@...ess.net>