[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202107240822.jkl1ur38-lkp@intel.com>
Date: Sat, 24 Jul 2021 08:56:38 +0800
From: kernel test robot <lkp@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: kbuild-all@...ts.01.org, netdev@...r.kernel.org,
Oleksij Rempel <o.rempel@...gutronix.de>,
Dan Murphy <dmurphy@...com>, kernel@...gutronix.de,
linux-kernel@...r.kernel.org, David Jander <david@...tonic.nl>
Subject: Re: [PATCH net-next v1 1/1] net: phy: dp83td510: Add basic support
for the DP83TD510 Ethernet PHY
Hi Oleksij,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Oleksij-Rempel/net-phy-dp83td510-Add-basic-support-for-the-DP83TD510-Ethernet-PHY/20210723-184426
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4431531c482a2c05126caaa9fcc5053a4a5c495b
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b58ac37ec2e1ecf8d19fd6f7da3d8d23ddc92d61
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oleksij-Rempel/net-phy-dp83td510-Add-basic-support-for-the-DP83TD510-Ethernet-PHY/20210723-184426
git checkout b58ac37ec2e1ecf8d19fd6f7da3d8d23ddc92d61
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/net/phy/dp83td510.c: In function 'dp83td510_strap':
>> drivers/net/phy/dp83td510.c:237:37: warning: variable 'rx_ctrl' set but not used [-Wunused-but-set-variable]
237 | int tx_vpp, pin18, rx_trap, pin30, rx_ctrl;
| ^~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +/rx_ctrl +237 drivers/net/phy/dp83td510.c
234
235 static int dp83td510_strap(struct phy_device *phydev)
236 {
> 237 int tx_vpp, pin18, rx_trap, pin30, rx_ctrl;
238 enum dp83td510_xmii_mode xmii_mode;
239 int sor0, sor1;
240 u8 addr;
241
242 sor0 = dp83td510_read(phydev, DP83TD510_SOR_0);
243 if (sor0 < 0)
244 return sor0;
245
246 rx_trap = FIELD_GET(DP83TD510_SOR_0_GPIO2, sor0);
247
248 sor1 = dp83td510_read(phydev, DP83TD510_SOR_1);
249 if (sor1 < 0)
250 return sor0;
251
252 addr = FIELD_GET(DP83TD510_SOR_1_RX_D3, sor1) << 3 |
253 FIELD_GET(DP83TD510_SOR_1_RX_D0, sor1) << 2 |
254 FIELD_GET(DP83TD510_SOR_1_RX_ER, sor1) << 1 |
255 FIELD_GET(DP83TD510_SOR_1_GPIO1, sor1) << 0;
256
257 tx_vpp = FIELD_GET(DP83TD510_SOR_1_LED_2, sor1);
258 xmii_mode = FIELD_GET(DP83TD510_SOR_1_LED_0, sor1) << 1 |
259 FIELD_GET(DP83TD510_SOR_1_RX_D1, sor1) << 0;
260 pin18 = FIELD_GET(DP83TD510_SOR_1_RX_D2, sor1);
261 pin30 = FIELD_GET(DP83TD510_SOR_1_CLK_OUT, sor1);
262 rx_ctrl = FIELD_GET(DP83TD510_SOR_1_RX_CTRL, sor1);
263
264 phydev_info(phydev,
265 "bootstrap cfg: Pin 18: %s, Pin 30: %s, TX Vpp: %s, RX trap: %s, xMII mode: %s, PHY addr: 0x%x\n",
266 pin18 ? "RX_DV" : "CRS_DV",
267 pin30 ? "LED_1" : "CLKOUT",
268 tx_vpp ? "1.0V p2p" : "2.4V & 1.0V p2p",
269 rx_trap ? "< 40Ω" : "50Ω",
270 dp83td510_get_xmii_mode_str(xmii_mode),
271 addr);
272
273 return 0;
274 }
275
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (55015 bytes)
Powered by blists - more mailing lists