linux-kernel - Re: [PATCH] dm io: fix comments to align with on-stack plugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee68b3ff-2448-9c6b-acbe-f4f0b5585f48@linux.alibaba.com>
Date:   Sat, 24 Jul 2021 10:31:44 +0800
From:   Xianting Tian <xianting.tian@...ux.alibaba.com>
To:     agk@...hat.com, snitzer@...hat.com
Cc:     dm-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dm io: fix comments to align with on-stack plugging

Could I get the comments for the patch?  thanks

在 2021/7/17 下午11:54, Xianting Tian 写道:
> From: Xianting Tian <xianting.tian@...ux.alibaba.com>
>
> Ther is no unplugging timer now, on-stack io plugging is used:
> 	struct blk_plug plug;
>
> 	blk_start_plug(&plug);
> 	submit_batch_of_io();
> 	blk_finish_plug(&plug);
>
> So remove the old comments for unplugging timer.
>
> Signed-off-by: Xianting Tian <xianting.tian@...ux.alibaba.com>
> ---
>   drivers/md/dm-io.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
> index 2d3cda0..7dba193 100644
> --- a/drivers/md/dm-io.c
> +++ b/drivers/md/dm-io.c
> @@ -528,11 +528,6 @@ static int dp_init(struct dm_io_request *io_req, struct dpages *dp,
>   
>   /*
>    * New collapsed (a)synchronous interface.
> - *
> - * If the IO is asynchronous (i.e. it has notify.fn), you must either unplug
> - * the queue with blk_unplug() some time later or set REQ_SYNC in
> - * io_req->bi_opf. If you fail to do one of these, the IO will be submitted to
> - * the disk after q->unplug_delay, which defaults to 3ms in blk-settings.c.
>    */
>   int dm_io(struct dm_io_request *io_req, unsigned num_regions,
>   	  struct dm_io_region *where, unsigned long *sync_error_bits)