lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202107241133.DPHaFF7n-lkp@intel.com>
Date:   Sat, 24 Jul 2021 11:08:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Alex Deucher <alexander.deucher@....com>
Subject: [agd5f:amd-staging-drm-next 177/352]
 drivers/gpu/drm/vc4/vc4_hdmi.c:172:39: warning: passing argument 1 of
 'gpio_get_value_cansleep' makes integer from pointer without a cast

tree:   https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head:   5f6579b064ef4cf9ed196c9b34762a6d995b1fbb
commit: 0600a948942d72a44f4306359075063a96b7e516 [177/352] Merge tag 'v5.13' into amd-staging-drm-next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
        git fetch --no-tags agd5f amd-staging-drm-next
        git checkout 0600a948942d72a44f4306359075063a96b7e516
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_hdmi_connector_detect':
>> drivers/gpu/drm/vc4/vc4_hdmi.c:172:39: warning: passing argument 1 of 'gpio_get_value_cansleep' makes integer from pointer without a cast [-Wint-conversion]
     172 |   if (gpio_get_value_cansleep(vc4_hdmi->hpd_gpio) ^
         |                               ~~~~~~~~^~~~~~~~~~
         |                                       |
         |                                       struct gpio_desc *
   In file included from include/linux/gpio.h:62,
                    from include/linux/of_gpio.h:15,
                    from drivers/gpu/drm/vc4/vc4_hdmi.c:43:
   include/asm-generic/gpio.h:82:52: note: expected 'unsigned int' but argument is of type 'struct gpio_desc *'
      82 | static inline int gpio_get_value_cansleep(unsigned gpio)
         |                                           ~~~~~~~~~^~~~
   drivers/gpu/drm/vc4/vc4_hdmi.c:173:15: error: 'struct vc4_hdmi' has no member named 'hpd_active_low'
     173 |       vc4_hdmi->hpd_active_low)
         |               ^~


vim +/gpio_get_value_cansleep +172 drivers/gpu/drm/vc4/vc4_hdmi.c

47fa9a80270e20 Maxime Ripard 2021-01-11  162  
c8b75bca92cbf0 Eric Anholt   2015-03-02  163  static enum drm_connector_status
c8b75bca92cbf0 Eric Anholt   2015-03-02  164  vc4_hdmi_connector_detect(struct drm_connector *connector, bool force)
c8b75bca92cbf0 Eric Anholt   2015-03-02  165  {
5dfbcae63f1098 Maxime Ripard 2020-09-03  166  	struct vc4_hdmi *vc4_hdmi = connector_to_vc4_hdmi(connector);
4d8602b8ec16f5 Dom Cobley    2021-01-11  167  	bool connected = false;
c8b75bca92cbf0 Eric Anholt   2015-03-02  168  
9984d6664ce9dc Maxime Ripard 2021-05-25  169  	WARN_ON(pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev));
9984d6664ce9dc Maxime Ripard 2021-05-25  170  
b10db9a4242bd5 Maxime Ripard 2020-09-03  171  	if (vc4_hdmi->hpd_gpio) {
b10db9a4242bd5 Maxime Ripard 2020-09-03 @172  		if (gpio_get_value_cansleep(vc4_hdmi->hpd_gpio) ^
b10db9a4242bd5 Maxime Ripard 2020-09-03  173  		    vc4_hdmi->hpd_active_low)
4d8602b8ec16f5 Dom Cobley    2021-01-11  174  			connected = true;
4d8602b8ec16f5 Dom Cobley    2021-01-11  175  	} else if (drm_probe_ddc(vc4_hdmi->ddc)) {
4d8602b8ec16f5 Dom Cobley    2021-01-11  176  		connected = true;
4d8602b8ec16f5 Dom Cobley    2021-01-11  177  	} else if (HDMI_READ(HDMI_HOTPLUG) & VC4_HDMI_HOTPLUG_CONNECTED) {
4d8602b8ec16f5 Dom Cobley    2021-01-11  178  		connected = true;
c8b75bca92cbf0 Eric Anholt   2015-03-02  179  	}
c8b75bca92cbf0 Eric Anholt   2015-03-02  180  
4d8602b8ec16f5 Dom Cobley    2021-01-11  181  	if (connected) {
4d8602b8ec16f5 Dom Cobley    2021-01-11  182  		if (connector->status != connector_status_connected) {
4d8602b8ec16f5 Dom Cobley    2021-01-11  183  			struct edid *edid = drm_get_edid(connector, vc4_hdmi->ddc);
4d8602b8ec16f5 Dom Cobley    2021-01-11  184  
4d8602b8ec16f5 Dom Cobley    2021-01-11  185  			if (edid) {
4d8602b8ec16f5 Dom Cobley    2021-01-11  186  				cec_s_phys_addr_from_edid(vc4_hdmi->cec_adap, edid);
4d8602b8ec16f5 Dom Cobley    2021-01-11  187  				vc4_hdmi->encoder.hdmi_monitor = drm_detect_hdmi_monitor(edid);
4d8602b8ec16f5 Dom Cobley    2021-01-11  188  				kfree(edid);
4d8602b8ec16f5 Dom Cobley    2021-01-11  189  			}
4d8602b8ec16f5 Dom Cobley    2021-01-11  190  		}
9d44abbbb8d530 Eric Anholt   2016-09-14  191  
9984d6664ce9dc Maxime Ripard 2021-05-25  192  		pm_runtime_put(&vc4_hdmi->pdev->dev);
c8b75bca92cbf0 Eric Anholt   2015-03-02  193  		return connector_status_connected;
4d8602b8ec16f5 Dom Cobley    2021-01-11  194  	}
4d8602b8ec16f5 Dom Cobley    2021-01-11  195  
b10db9a4242bd5 Maxime Ripard 2020-09-03  196  	cec_phys_addr_invalidate(vc4_hdmi->cec_adap);
9984d6664ce9dc Maxime Ripard 2021-05-25  197  	pm_runtime_put(&vc4_hdmi->pdev->dev);
c8b75bca92cbf0 Eric Anholt   2015-03-02  198  	return connector_status_disconnected;
c8b75bca92cbf0 Eric Anholt   2015-03-02  199  }
c8b75bca92cbf0 Eric Anholt   2015-03-02  200  

:::::: The code at line 172 was first introduced by commit
:::::: b10db9a4242bd5c89f0029e92ff13f2d7e9c53c8 drm/vc4: hdmi: Use local vc4_hdmi directly

:::::: TO: Maxime Ripard <maxime@...no.tech>
:::::: CC: Maxime Ripard <maxime@...no.tech>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (73298 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ