linux-kernel - [agd5f:amd-staging-drm-next 183/352] drivers/acpi/x86/utils.c:153:25: sparse: sparse: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 24 Jul 2021 13:30:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Alex Deucher <alexander.deucher@....com>
Subject: [agd5f:amd-staging-drm-next 183/352]
 drivers/acpi/x86/utils.c:153:25: sparse: sparse: symbol 'storage_d3_cpu_ids'
 was not declared. Should it be static?

tree:   https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head:   5f6579b064ef4cf9ed196c9b34762a6d995b1fbb
commit: 9ca3f9bb1084135a8404141c0a64b1f1a3a95fb3 [183/352] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint
config: x86_64-randconfig-s031-20210723 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
        git fetch --no-tags agd5f amd-staging-drm-next
        git checkout 9ca3f9bb1084135a8404141c0a64b1f1a3a95fb3
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/acpi/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/acpi/x86/utils.c:153:25: sparse: sparse: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?

vim +/storage_d3_cpu_ids +153 drivers/acpi/x86/utils.c

   138	
   139	/*
   140	 * AMD systems from Renoir and Lucienne *require* that the NVME controller
   141	 * is put into D3 over a Modern Standby / suspend-to-idle cycle.
   142	 *
   143	 * This is "typically" accomplished using the `StorageD3Enable`
   144	 * property in the _DSD that is checked via the `acpi_storage_d3` function
   145	 * but this property was introduced after many of these systems launched
   146	 * and most OEM systems don't have it in their BIOS.
   147	 *
   148	 * The Microsoft documentation for StorageD3Enable mentioned that Windows has
   149	 * a hardcoded allowlist for D3 support, which was used for these platforms.
   150	 *
   151	 * This allows quirking on Linux in a similar fashion.
   152	 */
 > 153	const struct x86_cpu_id storage_d3_cpu_ids[] = {
   154		X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL),	/* Renoir */
   155		X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL),	/* Lucienne */
   156		{}
   157	};
   158	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33851 bytes)