linux-kernel - Re: [PATCH 09/18] staging: rtl8188eu: remove unused _HAL_INTF_C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bfef837-e8f6-0a89-b0ac-967de12ed067@wanadoo.fr>
Date:   Sun, 25 Jul 2021 18:32:10 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/18] staging: rtl8188eu: remove unused _HAL_INTF_C_
 define

Le 25/07/2021 à 17:58, Martin Kaiser a écrit :
> This define can be removed.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/rtl8188eu/hal/hal_intf.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c
> index f09620c54e69..3e132e00c81c 100644
> --- a/drivers/staging/rtl8188eu/hal/hal_intf.c
> +++ b/drivers/staging/rtl8188eu/hal/hal_intf.c
> @@ -5,7 +5,6 @@
>    *
>    ******************************************************************************/
>   
> -#define _HAL_INTF_C_
>   #include <hal_intf.h>
>   
>   uint rtw_hal_init(struct adapter *adapt)
> 

Hi,

This one looks like an include guard.

#ifndef _HAL_INTF_C_
#define _HAL_INTF_C_
...
#endif /* _HAL_INTF_C_ */

?