linux-kernel - Re: [PATCH v3 5/5] dt-bindings: iio/adc: ingenic: add the JZ4760(B) socs to the sadc Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <QFNSWQ.A2MDJFJLHT1F2@crapouillou.net>
Date:   Sun, 25 Jul 2021 10:23:50 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Christophe Branchereau <cbranchereau@...il.com>
Cc:     jic23@...nel.org, lars@...afoo.de, linux-mips@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org, linux@...ck-us.net,
        contact@...ur-rojek.eu
Subject: Re: [PATCH v3 5/5] dt-bindings: iio/adc: ingenic: add the JZ4760(B)
 socs to the sadc Documentation

Hi Christophe,

Le sam., juil. 24 2021 at 21:04:49 +0200, Christophe Branchereau 
<cbranchereau@...il.com> a écrit :
> Add both the jz4760 and jz4760b, plus a property to use the internal
> divider on the b variant and document it.
> 
> Signed-off-by: Christophe Branchereau <cbranchereau@...il.com>

Looks good.

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

> ---
>  .../bindings/iio/adc/ingenic,adc.yaml         | 19 
> +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git 
> a/Documentation/devicetree/bindings/iio/adc/ingenic,adc.yaml 
> b/Documentation/devicetree/bindings/iio/adc/ingenic,adc.yaml
> index 433a3fb55a2e..3eb7aa8822c3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ingenic,adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ingenic,adc.yaml
> @@ -23,6 +23,8 @@ properties:
>      enum:
>        - ingenic,jz4725b-adc
>        - ingenic,jz4740-adc
> +      - ingenic,jz4760-adc
> +      - ingenic,jz4760b-adc
>        - ingenic,jz4770-adc
> 
>    '#io-channel-cells':
> @@ -43,6 +45,23 @@ properties:
>    interrupts:
>      maxItems: 1
> 
> +  ingenic,use-internal-divider:
> +    description:
> +      If present, battery voltage is read from the VBAT_IR pin, 
> which has an
> +      internal 1/4 divider. If absent, it is read through the 
> VBAT_ER pin,
> +      which does not have such a divider.
> +    type: boolean
> +
> +if:
> +  not:
> +    properties:
> +      compatible:
> +        contains:
> +          const: ingenic,jz4760b-adc
> +then:
> +  properties:
> +    ingenic,use-internal-divider: false
> +
>  required:
>    - compatible
>    - '#io-channel-cells'
> --
> 2.30.2
>