lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Jul 2021 13:10:49 +0300 From: Leon Romanovsky <leon@...nel.org> To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> Cc: saeedm@...dia.com, davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] net/mlx5: Fix missing return value in mlx5_devlink_eswitch_inline_mode_set() On Thu, Jul 22, 2021 at 05:58:16PM +0800, Jiapeng Chong wrote: > The return value is missing in this code scenario, add the return value > '0' to the return value 'err'. > > Eliminate the follow smatch warning: > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:3083 > mlx5_devlink_eswitch_inline_mode_set() warn: missing error code 'err'. > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com> > Fixes: 8e0aa4bc959c ("net/mlx5: E-switch, Protect eswitch mode changes") > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> > --- > Changes in v2: > -For the follow advice: https://lore.kernel.org/patchwork/patch/1461601/ > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists