linux-kernel - Re: [PATCH 3/4] iio: st_sensors: remove all driver remove functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vem3Q5vRknvWrZSsX4_+2j7fGtU6RcLzCHEr2AA67eZfA@mail.gmail.com>
Date:   Mon, 26 Jul 2021 10:20:07 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <aardelean@...iqon.com>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Denis Ciocca <denis.ciocca@...com>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH 3/4] iio: st_sensors: remove all driver remove functions

On Mon, Jul 26, 2021 at 10:14 AM Alexandru Ardelean
<aardelean@...iqon.com> wrote:
>
> At this point all ST driver remove functions do iio_device_unregister().
> This change removes them from them and replaces all iio_device_register()
> with devm_iio_device_register().
>
> This can be done in a single change relatively easy, since all these remove

easily

> functions are define in st_sensors.h.

defined

>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h      |  1 -
>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c | 15 +--------------
>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c  |  6 ------
>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c  |  6 ------

I will check these later on, but the rule of thumb about devm_*() is
that there shouldn't be gaps (non-devm) before any devm call.

-- 
With Best Regards,
Andy Shevchenko