linux-kernel - Re: [PATCH v5 2/2] cpupower: Fix to return negative value if no permisssion for read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2d0dd861-b62e-5bb0-79ba-0be05f0d6028@linuxfoundation.org>
Date:   Mon, 26 Jul 2021 14:04:38 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     徐福海 <xufuhai1992@...il.com>, shuah@...nel.org,
        Thomas Renninger <trenn@...e.com>
Cc:     xufuhai <xufuhai@...ishou.com>, lishujin@...ishou.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v5 2/2] cpupower: Fix to return negative value if no
 permisssion for read_msr

On 7/23/21 12:26 AM, 徐福海 wrote:
> From: xufuhai<xufuhai1992@...il.com>  <mailto:xufuhai@...ishou.com>
> 
> If the read_msr function is executed by a non-root user, the function returns
> -1, which means that there is no permission to access//dev/cpu//%d/msr, but
> cpufreq_has_boost_support should also return -1 immediately, and should not
> follow the original logic to return 0, which will cause amd The cpupower tool
> returns the boost active state as 0.
> 
> Reproduce procedure:
>          cpupower frequency-info
> 
> Reported-by:   yangrui<yangrui@...ishou.com>  <mailto:yangrui@...ishou.com>
> Signed-off-by: xufuhai<xufuhai1992@...il.com>  <mailto:xufuhai@...ishou.com>
> Signed-off-by: chenguanqiao<chenguanqiao@...ishou.com>  <mailto:chenguanqiao@...ishou.com>
> Signed-off-by: lishujin<lishujin@...ishou.com>  <mailto:lishujin@...ishou.com>

Please use your full names for the Signed-off-by - similar to the way you
would sign a legal document.

thanks,
-- Shuah