lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 26 Jul 2021 23:37:38 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andre Przywara <andre.przywara@....com>
Cc:     Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        Will Deacon <will@...nel.org>, Ali Saidi <alisaidi@...zon.com>,
        Jon Nettleton <jon@...id-run.com>
Subject: Re: [PATCH v3 2/2] hwrng: Add Arm SMCCC TRNG based driver

On Mon, Jul 26, 2021 at 06:56:10PM +0100, Andre Przywara wrote:

> +static int smccc_trng_init(struct hwrng *rng)
> +{
> +	return 0;
> +}

If this can be empty (looking at the core it seems like it can) then
best just remove it.

> +	platform_set_drvdata(pdev, trng);
> +	ret = devm_hwrng_register(&pdev->dev, trng);
> +	if (!ret)
> +		dev_info(&pdev->dev,
> +			 "ARM SMCCC TRNG firmware random number generator\n");

Is the log message needed given that we're not announcing any version
information here or anything?  A brief sampling of other drivers
suggests it's not a standard thing for the subsystem.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists