linux-kernel - Re: [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2m3BB2=4gkHXZD+=y1C47Og0QvfTWuA7e28oAonMyvzw@mail.gmail.com>
Date:   Mon, 26 Jul 2021 10:11:32 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Jean-Philippe Brucker <jean-philippe@...aro.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Bill Mills <bill.mills@...aro.org>,
        Alex Bennée <alex.bennee@...aro.org>,
        "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        Jie Deng <jie.deng@...el.com>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" 
        <virtualization@...ts.linux-foundation.org>,
        Wolfram Sang <wsa@...nel.org>,
        Linux I2C <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio

On Mon, Jul 26, 2021 at 10:06 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> On Mon, Jul 26, 2021 at 6:52 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
> >
> > This patch adds binding for virtio I2C device, it is based on
> > virtio-device bindings.
> >
> > Acked-by: Wolfram Sang <wsa@...nel.org>
> > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>

Too quick, after seeing the same issue in the gpio binding I saw it here too:

> +        i2c-virtio {
> +            compatible = "virtio,22";

The node name "i2c-virtio" looks wrong. According to
https://github.com/devicetree-org/dt-schema/blob/master/schemas/i2c/i2c-controller.yaml,
this needs to be plain "i2c".

       Arnd