linux-kernel - Re: [PATCH] opp: remove WARN when no valid OPPs remain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210726090230.ghsxqzv3pjw55ell@vireshk-i7>
Date:   Mon, 26 Jul 2021 14:32:30 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] opp: remove WARN when no valid OPPs remain

On 26-07-21, 10:30, Michał Mirosław wrote:
> This WARN can be triggered per-core and the stack trace is not useful.
> Replace it with plain dev_err(). Fix a comment while at it.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
>  drivers/opp/of.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index c582a9ca397b..01feeba78426 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -985,8 +985,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
>  		}
>  	}
>  
> -	/* There should be one of more OPP defined */
> -	if (WARN_ON(!count)) {
> +	/* There should be one or more OPPs defined */
> +	if (!count) {
> +		dev_err(dev, "%s: no supported OPPs", __func__);
>  		ret = -ENOENT;
>  		goto remove_static_opp;
>  	}

Applied. Thanks.

-- 
viresh