linux-kernel - Re: [PATCH 2/4] vp_vdpa: Fix return value check for vdpa_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210726092836.3iokq436ffwpwt3q@steredhat>
Date:   Mon, 26 Jul 2021 11:28:36 +0200
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Xie Yongji <xieyongji@...edance.com>
Cc:     mst@...hat.com, jasowang@...hat.com, dan.carpenter@...cle.com,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] vp_vdpa: Fix return value check for
 vdpa_alloc_device()

On Thu, Jul 15, 2021 at 04:00:24PM +0800, Xie Yongji wrote:
>The vdpa_alloc_device() returns an error pointer upon
>failure, not NULL. To handle the failure correctly, this
>replaces NULL check with IS_ERR() check and propagate the
>error upwards.
>
>Fixes: 64b9f64f80a6 ("vdpa: introduce virtio pci driver")
>Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>Signed-off-by: Xie Yongji <xieyongji@...edance.com>
>---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
>index 7b4a6396c553..fe0527329857 100644
>--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
>+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
>@@ -436,9 +436,9 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>
> 	vp_vdpa = vdpa_alloc_device(struct vp_vdpa, vdpa,
> 				    dev, &vp_vdpa_ops, NULL);
>-	if (vp_vdpa == NULL) {
>+	if (IS_ERR(vp_vdpa)) {
> 		dev_err(dev, "vp_vdpa: Failed to allocate vDPA structure\n");
>-		return -ENOMEM;
>+		return PTR_ERR(vp_vdpa);
> 	}
>
> 	mdev = &vp_vdpa->mdev;
>-- 
>2.11.0
>

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>