linux-kernel - Re: [PATCH] media: atmel: fix build when ISC=m and XISC=y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44a267f7-d01d-36de-0a14-0fa0eb14b6ea@microchip.com>
Date:   Mon, 26 Jul 2021 09:52:53 +0000
From:   <Eugen.Hristev@...rochip.com>
To:     <linux-media@...r.kernel.org>, <hverkuil-cisco@...all.nl>,
        <arnd@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <lkp@...el.com>
Subject: Re: [PATCH] media: atmel: fix build when ISC=m and XISC=y

On 7/5/21 3:57 PM, Eugen Hristev wrote:
> Building VIDEO_ATMEL_ISC as module and VIDEO_ATMEL_XISC as built-in
> (or viceversa) causes build errors:
> 
>   or1k-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o: in function `isc_async_complete':
>   atmel-isc-base.c:(.text+0x40d0): undefined reference to `__this_module'
>   or1k-linux-ld: atmel-isc-base.c:(.text+0x40f0): undefined reference to `__this_module'
>   or1k-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(.rodata+0x390): undefined reference to `__this_module'
>   or1k-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(__param+0x4): undefined reference to `__this_module'
>   or1k-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(__param+0x18): undefined reference to `__this_module'
> 
> This is caused by the file atmel-isc-base.c which is common code between
> the two drivers.
> 
> The solution is to create another Kconfig symbol that is automatically
> selected and generates the module atmel-isc-base.ko. This module can be
> loaded when both drivers are modules, or built-in when at least one of them
> is built-in.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: c9aa973884a1 ("media: atmel: atmel-isc: add microchip-xisc driver")
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>
> ---

Hello Hans,

This build problem is causing plenty of robot reports and issues in 
current 5.14 tree, also Arnd has sent a similar patch after mine was sent.

Could you have a look please such that we fix this for 5.14 ?

Thanks,
Eugen