linux-kernel - Re: [PATCH] spi: stm32: fix excluded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jul 2021 11:55:32 +0200
From:   Alain Volmat <alain.volmat@...s.st.com>
To:     kernel test robot <lkp@...el.com>
CC:     <kbuild-all@...ts.01.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Mark Brown <broonie@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <linux-spi@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: stm32: fix excluded_middle.cocci warnings

Thanks.

Reviewed-by: Alain Volmat <alain.volmat@...s.st.com>

On Wed, Jul 14, 2021 at 03:10:04AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@...el.com>
> 
> drivers/spi/spi-stm32.c:915:23-25: WARNING !A || A && B is equivalent to !A || B
> 
> 
>  Condition !A || A && B is equivalent to !A || B.
> 
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
> 
> Fixes: 7ceb0b8a3ced ("spi: stm32: finalize message either on dma callback or EOT")
> CC: Alain Volmat <alain.volmat@...s.st.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   8f0df15bafc1e1c92b6d96bf8ef24dd8be3aec7b
> commit: 7ceb0b8a3ceddc36ae4ef1cba6c25a0e28ed65fc [1012/1340] spi: stm32: finalize message either on dma callback or EOT
> :::::: branch date: 11 hours ago
> :::::: commit date: 2 days ago
> 
>  spi-stm32.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -912,8 +912,7 @@ static irqreturn_t stm32h7_spi_irq_threa
>  		if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0)))
>  			stm32h7_spi_read_rxfifo(spi);
>  		if (!spi->cur_usedma ||
> -		    (spi->cur_usedma && (spi->cur_comm == SPI_SIMPLEX_TX ||
> -		     spi->cur_comm == SPI_3WIRE_TX)))
> +		    (spi->cur_comm == SPI_SIMPLEX_TX || spi->cur_comm == SPI_3WIRE_TX))
>  			end = true;
>  	}
>