linux-kernel - Re: [PATCH] regmap: do not call regmap_debugfs_init() from regmap_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210726120013.GF4670@sirena.org.uk>
Date:   Mon, 26 Jul 2021 13:00:13 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        David Lechner <david@...hnology.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: do not call regmap_debugfs_init() from
 regmap_attach_dev()

On Mon, Jul 26, 2021 at 09:36:27AM +0200, Matthias Schiffer wrote:

> lacking) understanding of the semantics aside, the fact that
> regmap_attach_dev() is setting fields on the shared regmap without any
> kind of locking is at least suspicious.

BTW there shouldn't be any harm in adding locking, but we're really
hoping that it shouldn't be required here as the caller ought to be
doing coordination which means things are single threaded anyway so we
didn't bother.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)