linux-kernel - Re: [syzbot] BUG: sleeping function called from invalid context in folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YP6udKVlejbnTOiw@casper.infradead.org>
Date:   Mon, 26 Jul 2021 13:45:40 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     syzbot <syzbot+bb4c69145b4a52b40b27@...kaller.appspotmail.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] BUG: sleeping function called from invalid context in
 folio_copy

On Sun, Jul 25, 2021 at 10:18:34PM -0700, Andrew Morton wrote:
> (Cc Matthew)
> 
> (It might not be a folio thing at all - I haven't checked yet)

Already fixed, thanks.  folio_copy() had a cond_resched() in it,
even if it was only copying a single page.  Now it only calls
cond_resched() if it's copying more than one page.

We discussed this in the folio call on Friday, because we're leaving a
bit of a landmine here for whoever tries to make multi-page folios work
with buffer_heads.  There's not much we can do about it for now; it'll
just be one of the many problems to be dealt with.  Hopefully filesystems
will convert to iomap instead of trying to make buffer_heads support
multiple pages.