[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VdYUUqVi6rd6C-W+1aTXCPs7ehSLDcRfo4RVe7XU+6c+A@mail.gmail.com>
Date: Mon, 26 Jul 2021 16:40:46 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Jan Kiszka <jan.kiszka@...mens.com>
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
linux-watchdog@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Paolo Bonzini <pbonzini@...hat.com>,
Christian Storm <christian.storm@...mens.com>,
Mantas Mikulėnas <grawity@...il.com>
Subject: Re: [PATCH] watchdog: iTCO_wdt: Fix detection of SMI-off case
On Mon, Jul 26, 2021 at 3:04 PM Jan Kiszka <jan.kiszka@...mens.com> wrote:
>
> On 26.07.21 14:01, Andy Shevchenko wrote:
> > On Mon, Jul 26, 2021 at 2:46 PM Jan Kiszka <jan.kiszka@...mens.com> wrote:
> >>
> >> From: Jan Kiszka <jan.kiszka@...mens.com>
> >>
> >> Obviously, the test needs to run against the register content, not its
> >> address.
> >>
> >> Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on second timeout")
> >> Reported-by: Mantas Mikulėnas <grawity@...il.com>
> >
> >> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> >
> > Missed SoB of the submitter (hint: configure your Git to make sure
> > that submitter and author are the same in terms of name-email).
>
> The signed off is there. Not sure what you are referring to.
Nope. It's not. The sign of that is the From: line in the body of the
email. It happens when the submitter != author. And SoB of the former
one is absent. But what is strange is that reading them here I haven't
found the difference. Maybe one is in UTF-8 while the other is not and
a unicode character degraded to Latin-1 or so?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists