linux-kernel - Re: [PATCH v2 1/2] perf env: Normalize aarch64.* and arm64.* to arm64 in normalize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9530d369-cf59-ee80-69e9-b8d4ae24182f@arm.com>
Date:   Mon, 26 Jul 2021 16:18:17 +0100
From:   James Clark <james.clark@....com>
To:     Li Huafei <lihuafei1@...wei.com>, acme@...nel.org, jolsa@...nel.org
Cc:     peterz@...radead.org, mark.rutland@....com, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        mliska@...e.cz, irogers@...gle.com, dzhu@...ecomp.com,
        rickyman7@...il.com, yao.jin@...ux.intel.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhangjinhao2@...wei.com
Subject: Re: [PATCH v2 1/2] perf env: Normalize aarch64.* and arm64.* to arm64
 in normalize_arch()



On 26/07/2021 13:38, Li Huafei wrote:
> On my aarch64 big endian machine, the perf annotate does not work.
> 
>  # perf annotate
>   Percent |      Source code & Disassembly of [kernel.kallsyms] for cycles (253 samples, percent: local period)
>  --------------------------------------------------------------------------------------------------------------
>   Percent |      Source code & Disassembly of [kernel.kallsyms] for cycles (1 samples, percent: local period)
>  ------------------------------------------------------------------------------------------------------------
>   Percent |      Source code & Disassembly of [kernel.kallsyms] for cycles (47 samples, percent: local period)
>  -------------------------------------------------------------------------------------------------------------
>  ...
> 
> This is because the arch_find() function uses the normalized architecture
> name provided by normalize_arch(), and my machine's architecture name
> aarch64_be is not normalized to arm64.  Like other architectures such as
> arm and powerpc, we can fuzzy match the architecture names associated with
> aarch64.* and normalize them.
> 
> It seems that there is also arm64_be architecture name, which we also
> normalize to arm64.
> 
> Signed-off-by: Li Huafei <lihuafei1@...wei.com>
> ---
> Changes in v2:
>  - The error log added in symbol__annotate() is put into a single patch
>  - Remove the "Fixes" tag
>  - According to James' suggestion, "arm64_be" is also normalized to
>    "arm64"
> 
>  tools/perf/util/env.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c
> index cec2e6cad8aa..ab341050be46 100644
> --- a/tools/perf/util/env.c
> +++ b/tools/perf/util/env.c
> @@ -349,7 +349,7 @@ static const char *normalize_arch(char *arch)
>  		return "x86";
>  	if (!strcmp(arch, "sun4u") || !strncmp(arch, "sparc", 5))
>  		return "sparc";
> -	if (!strcmp(arch, "aarch64") || !strcmp(arch, "arm64"))
> +	if (!strncmp(arch, "aarch64", 7) || !strncmp(arch, "arm64", 5))
>  		return "arm64";
>  	if (!strncmp(arch, "arm", 3) || !strcmp(arch, "sa110"))
>  		return "arm";
> 

Reviewed-by: James Clark <james.clark@....com>