linux-kernel - Re: [PATCH] vfio: Add "#ifdef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210727120116.61ba8e25.alex.williamson@redhat.com>
Date:   Tue, 27 Jul 2021 12:01:16 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Cornelia Huck <cohuck@...hat.com>
Cc:     Cai Huoqing <caihuoqing@...du.com>, jgg@...pe.ca,
        eric.auger@...hat.com, kevin.tian@...el.com,
        giovanni.cabiddu@...el.com, mgurtovoy@...dia.com, jannh@...gle.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio: Add "#ifdef CONFIG_MMU" for vma operations

On Tue, 27 Jul 2021 18:35:14 +0200
Cornelia Huck <cohuck@...hat.com> wrote:

> On Tue, Jul 27 2021, Cai Huoqing <caihuoqing@...du.com> wrote:
> 
> > Add "#ifdef CONFIG_MMU",
> > because vma mmap and vm_operations_struct depend on MMU  
> 
> vfio_pci already depends on MMU -- what problems are you trying to fix?

Exactly my question, we silenced the randconfig builds without
CONFIG_MMU in commit 2a55ca373501 ("vfio/pci: zap_vma_ptes() needs
MMU").  Surely there are prototypes for vma_area_struct regardless of
CONFIG_MMU and vfio-core having an mmap callback has no dependency on
vm_operations_struct.  Thanks,

Alex