linux-kernel - Re: [PATCH v2] usb: gadget: f_hid: added GET_IDLE and SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Jul 2021 20:46:03 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Maxim Devaev <mdevaev@...il.com>
Cc:     balbi@...nel.org, sandeen@...hat.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: gadget: f_hid: added GET_IDLE and SET_IDLE
 handlers

On Tue, Jul 27, 2021 at 09:31:41PM +0300, Maxim Devaev wrote:
> The USB HID standard declares mandatory support for GET_IDLE and SET_IDLE
> requests for Boot Keyboard. Most hosts can handle their absence, but others
> like some old/strange UEFIs and BIOSes consider this a critical error
> and refuse to work with f_hid.
> 
> This primitive implementation of saving and returning idle is sufficient
> to meet the requirements of the standard and these devices.
> 
> Signed-off-by: Maxim Devaev <mdevaev@...il.com>
> ---
>  drivers/usb/gadget/function/f_hid.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

As I already took your first patch, and I can not drop it as it is a
public tree, can you just send me the fixup patch?  That would be
simpler than me reverting the original and then applying a "fixed"
version, right?

thanks,

greg k-h