linux-kernel - Re: [patch 10/50] locking/rtmutex: Provide rt_mutex_slowlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zgu7pokj.ffs@nanos.tec.linutronix.de>
Date:   Tue, 27 Jul 2021 21:02:52 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Valentin Schneider <valentin.schneider@....com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Will Deacon <will@...nel.org>,
        Waiman Long <longman@...hat.com>,
        Boqun Feng <boqun.feng@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Davidlohr Bueso <dave@...olabs.net>
Subject: Re: [patch 10/50] locking/rtmutex: Provide rt_mutex_slowlock_locked()

On Tue, Jul 27 2021 at 18:20, Valentin Schneider wrote:

> On 13/07/21 17:11, Thomas Gleixner wrote:
>> +/*
>> + * rt_mutex_slowlock - Locking slowpath invoked when fast path fails
>> + * @lock:	The rtmutex to block lock
>> + * @state:	The task state for sleeping
>> + */
>> +static int __sched rt_mutex_slowlock(struct rt_mutex *lock, unsigned int state)
>> +{
>> +	unsigned long flags;
>> +	int ret;
>>
>> -	debug_rt_mutex_free_waiter(&waiter);
>
> This does end up showing up in rtlock_slowlock_locked(), but disappears
> from the rtmutex path. AFAICT it should show up at the tail of
> __rt_mutex_slowlock_locked().

Indeed.