linux-kernel - Re: [PATCH] MIPS: Avoid macro redefinitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdmAxEUdSM-6g+pGHLdtzm1sRDoiPqMP_hWNLM9E4Kp7Dg@mail.gmail.com>
Date:   Tue, 27 Jul 2021 13:25:54 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Paul Cercueil <paul@...pouillou.net>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        list@...ndingux.net, Kees Cook <keescook@...omium.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] MIPS: Avoid macro redefinitions

On Wed, Jul 21, 2021 at 9:17 AM Thomas Bogendoerfer
<tsbogend@...ha.franken.de> wrote:
>
> On Mon, Jul 19, 2021 at 11:10:55PM +0100, Paul Cercueil wrote:
> > > >   #ifndef TOOLCHAIN_SUPPORTS_VIRT
> > >
> > > Same question for GAS version support for virt?
> > > Documentation/process/changes.rst
> > > says GNU binutils 2.23+ is required for building the kernel.
> > > If we still need to support, have you tested this change on such an
> > > older version of GNU binutils?
> >
> > I have no idea about virt support - I hope Thomas can answer this.
>
> virt support was added in 2.24 and xpa in 2.25. So we still need the
> TOOLCHAIN defines for it.

Ah, ok then. Thanks for finding that.  Perhaps Paul you can note that
in the v2 that removes the commented out line, then we should be good
to go?
-- 
Thanks,
~Nick Desaulniers