linux-kernel - Re: BUG: cannot enable iso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMMLpeTKcd+WijyEAnH9vkHjuF+_K9-_EvTXThCDOhoeucNyHg@mail.gmail.com>
Date:   Tue, 27 Jul 2021 15:58:59 -0600
From:   Alex Henrie <alexhenrie24@...il.com>
To:     José Expósito <jose.exposito89@...il.com>
Cc:     juw@...teo.de, Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: BUG: cannot enable iso_layout with apple keyboard

On Wed, Jul 14, 2021 at 1:57 AM José Expósito <jose.exposito89@...il.com> wrote:
>
> > Hi,
> >
> > I have an apple keyboard model A1644 EMC 2815 with Finnish/Swedish ISO layout. When I connect it via
> > cable it works fine. But when I connect it via bluetooth, then the buttons >/< and §/° are swapped.
> > It seems to make no difference if I set iso_layout to 0 or to 1. I checked and it turns out that
> > hid->country below equals 0, and removing the check
> >
> > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> > index 6b8f0d004d34..8a764ce4e518 100644
> > --- a/drivers/hid/hid-apple.c
> > +++ b/drivers/hid/hid-apple.c
> > @@ -267,13 +267,11 @@ static int hidinput_apple_event(struct hid_device *hid, struct input_dev *input,
> >         }
> >
> >         if (iso_layout) {
> > -               if (hid->country == HID_COUNTRY_INTERNATIONAL_ISO) {
> >                         trans = apple_find_translation(apple_iso_keyboard, usage->code);
> >                         if (trans) {
> >                                 input_event(input, usage->type, trans->to, value);
> >                                 return 1;
> >                         }
> > -               }
> >         }
> >
> >         if (swap_opt_cmd) {
> >
> > makes the buttons act correctly. Please let me know how I can help fixing this.
> >
> > Best regards,
> > Julian Weigt
>
> Hi Julian,
>
> I can confirm I can reproduce the issue with a Spanish/Spain keyboard.
>
> The problem seems to be that the field "bCountryCode" is not present when the keyboard is connected over bluetooth.
>
> CCing Alex Henrie, hopefully he can add useful information about the issue.
>
> Best wishes,
> Jose

Thanks Julian and José for bringing this to my attention. I also found
an Ubuntu bug report [1] which suggests that some of Apple's USB ISO
keyboards do not set the country code either. I have ordered a variety
of Apple keyboards from eBay for testing and I will send a fix as soon
as I am able.

-Alex

[1] https://bugs.launchpad.net/ubuntu/+source/xkeyboard-config/+bug/1886215