linux-kernel - Re: [PATCH v15] i2c: virtio: add a virtio i2c frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210727042335.lyzhkboh55aaqpy2@vireshk-i7>
Date:   Tue, 27 Jul 2021 09:53:35 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Jie Deng <jie.deng@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" 
        <virtualization@...ts.linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa@...nel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        yu1.wang@...el.com, conghui.chen@...el.com,
        Stefan Hajnoczi <stefanha@...hat.com>,
        gregkh <gregkh@...uxfoundation.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Alex Bennée <alex.bennee@...aro.org>,
        jiedeng@...mni.sjtu.edu.cn
Subject: Re: [PATCH v15] i2c: virtio: add a virtio i2c frontend driver

On 27-07-21, 10:15, Jie Deng wrote:
> 
> On 2021/7/23 17:03, Arnd Bergmann wrote:
> > On Fri, Jul 23, 2021 at 7:44 AM Jie Deng <jie.deng@...el.com> wrote:
> > 
> > > +
> > > +       ret = virtio_i2c_setup_vqs(vi);
> > > +       if (ret)
> > > +               return ret;
> > > +
> > > +       vi->adap.owner = THIS_MODULE;
> > > +       snprintf(vi->adap.name, sizeof(vi->adap.name),
> > > +                "i2c_virtio at virtio bus %d", vdev->index);
> > > +       vi->adap.algo = &virtio_algorithm;
> > > +       vi->adap.quirks = &virtio_i2c_quirks;
> > > +       vi->adap.dev.parent = &vdev->dev;
> > > +       i2c_set_adapdata(&vi->adap, vi);
> > > +
> > > +       /*
> > > +        * Setup ACPI node for controlled devices which will be probed through
> > > +        * ACPI.
> > > +        */
> > > +       ACPI_COMPANION_SET(&vi->adap.dev, ACPI_COMPANION(pdev));
> > Since there is now a generic way for virtio drivers to link up with OF
> > device nodes, maybe this should be handled the same way in the
> > virtio core rather than the driver?
> 
> 
> I'm currently based on the I2C tree. Has that patch been already merged ？
> 
> Anyway, I think we can send an additional patch to remove this line once
> that
> 
> "generic way" patch is merged.

I agree, we need to get this merged and do stuff on top of it. We are
already on v15 :)

-- 
viresh