linux-kernel - Re: [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of the gpio key

Open Source and information security mailing list archives

Message-ID: <030d92ba-920a-4b8e-b48a-d722e8fbca90@microchip.com>
Date:   Tue, 27 Jul 2021 11:56:19 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>
Subject: Re: [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of
 the gpio key

On 27/07/2021 at 11:13, nicolas.ferre@...rochip.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Ludovic Desroches <ludovic.desroches@...rochip.com>
> 
> Having a button code and not a key code causes issues with libinput.
> udev won't set ID_INPUT_KEY. If it is forced, then it causes a bug
> within libinput.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@...rochip.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

For the record: added to at91-dt for 5.15.

Regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 541779af049f..d241c24f0d83 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -7,6 +7,7 @@
>    */
>   /dts-v1/;
>   #include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> 
>   / {
>          model = "Atmel SAMA5D4 Xplained";
> @@ -250,7 +251,7 @@ gpio_keys {
>                  pb_user1 {
>                          label = "pb_user1";
>                          gpios = <&pioE 8 GPIO_ACTIVE_HIGH>;
> -                       linux,code = <0x100>;
> +                       linux,code = <KEY_PROG1>;
>                          wakeup-source;
>                  };
>          };
> --
> 2.32.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
Nicolas Ferre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives