linux-kernel - Re: [PATCH v3] drm/dsi: Add _NO_ to MIPI_DSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CANMq1KAVA3LRXzcKrVoj30KtvwuA0hQ12JdMLu32-RD8h=UjFw@mail.gmail.com>
Date:   Tue, 27 Jul 2021 18:29:08 +0800
From:   Nicolas Boichat <drinkcat@...omium.org>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Neil Armstrong <narmstrong@...libre.com>,
        David Airlie <airlied@...ux.ie>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Jordan Crouse <jordan@...micpenguin.net>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Andrzej Hajda <andrzej.hajda@...sung.com>,
        Joonyoung Shim <jy0922.shim@...sung.com>,
        Jonathan Marek <jonathan@...ek.ca>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        Adrien Grassein <adrien.grassein@...il.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Jonas Karlman <jonas@...boo.se>,
        MSM <linux-arm-msm@...r.kernel.org>,
        Yangtao Li <tiny.windzz@...il.com>,
        Abhinav Kumar <abhinavk@...eaurora.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sean Paul <sean@...rly.run>, Xin Ji <xji@...logixsemi.com>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        lkml <linux-kernel@...r.kernel.org>,
        Robert Foss <robert.foss@...aro.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Yu Jiahua <yujiahua1@...wei.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        freedreno <freedreno@...ts.freedesktop.org>
Subject: Re: [PATCH v3] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

On Tue, Jul 27, 2021 at 4:35 PM Sam Ravnborg <sam@...nborg.org> wrote:
>
> Hi Nicolas,
> On Tue, Jul 27, 2021 at 09:45:21AM +0800, Nicolas Boichat wrote:
> > Many of the DSI flags have names opposite to their actual effects,
> > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually
> > be disabled. Fix this by including _NO_ in the flag names, e.g.
> > MIPI_DSI_MODE_NO_EOT_PACKET.
> >
> > Signed-off-by: Nicolas Boichat <drinkcat@...omium.org>
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> > Reviewed-by: Robert Foss <robert.foss@...aro.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > Reviewed-by: Andrzej Hajda <andrzej.hajda@...sung.com>
> > Reviewed-by: Xin Ji <xji@...logixsemi.com> # anx7625.c
> > Reviewed-by: Abhinav Kumar <abhinavk@...eaurora.org> # msm/dsi
> > ---
> > I considered adding _DISABLE_ instead, but that'd make the
> > flag names a big too long.
> >
> > Generated with:
> > flag=MIPI_DSI_MODE_VIDEO_HFP; git grep $flag | cut -f1 -d':' | \
> >   xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HFP/" {}
> > flag=MIPI_DSI_MODE_VIDEO_HBP; git grep $flag | cut -f1 -d':' | \
> >   xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HBP/" {}
> > flag=MIPI_DSI_MODE_VIDEO_HSA; git grep $flag | cut -f1 -d':' | \
> >   xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HSA/" {}
> > flag=MIPI_DSI_MODE_EOT_PACKET; git grep $flag | cut -f1 -d':' | \
> >   xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_NO_EOT_PACKET/" {}
> > (then minor format changes)
> >
> > Changes in v3:
> >  - Added all R-b tags from v1 and v2 (hopefully didn't miss any).
> >
> > Changes in v2:
> >  - Rebased on latest linux-next, after some of the flags got fixed
> >    (Linus Walleij).
>
> Thanks for the update, applied to drm-misc-next.

Thanks Sam!

>
>         Sam