linux-kernel - Re: [RFC PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <98df594dccc9fb5ac857a00308118e6a48bc24a4.camel@intel.com>
Date:   Tue, 27 Jul 2021 01:48:40 +0000
From:   "Sakkinen, Jarkko" <jarkko.sakkinen@...el.com>
To:     "Luck, Tony" <tony.luck@...el.com>,
        "seanjc@...gle.com" <seanjc@...gle.com>
CC:     "Hansen, Dave" <dave.hansen@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [RFC PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages

On Tue, 2021-07-13 at 16:56 +0000, Sean Christopherson wrote:
> On Tue, Jun 08, 2021, Tony Luck wrote:
> > Add a type field to struct epc_page for how an in-use page has been
> > allocated. Re-use "enum sgx_page_type" for this type, with a couple
> > of additions for s/w types.
> 
> IMO, taking different actions based on the page type is flawed.  Ditto for adding
> a flag to track so called "dirty" pages.

I agree with this. Let's keep microarchitecture related
structures/enums separate from "software defined" things.

If such things add up (i.e. similar additions to something
else in future), it will be both hard to maintain, and also
the subsystem will be harder to understand for potential future
contributers.

/Jarkko