linux-kernel - Re: [PATCH] fs: make d_path-like functions all have unsigned size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YP/zK8WKGVyLXMqu@kroah.com>
Date:   Tue, 27 Jul 2021 13:51:07 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jordy Zomer <jordy@...ing.systems>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH] fs: make d_path-like functions all have unsigned size

On Tue, Jul 27, 2021 at 12:19:55PM +0100, Matthew Wilcox wrote:
> On Tue, Jul 27, 2021 at 12:36:25PM +0200, Greg Kroah-Hartman wrote:
> > When running static analysis tools to find where signed values could
> > potentially wrap the family of d_path() functions turn out to trigger a
> > lot of mess.  In evaluating the code, all of these usages seem safe, but
> > pointer math is involved so if a negative number is ever somehow passed
> > into these functions, memory can be traversed backwards in ways not
> > intended.
> 
> > diff --git a/fs/d_path.c b/fs/d_path.c
> > index 23a53f7b5c71..7876b741a47e 100644
> > --- a/fs/d_path.c
> > +++ b/fs/d_path.c
> > @@ -182,7 +182,7 @@ static int prepend_path(const struct path *path,
> >   */
> >  char *__d_path(const struct path *path,
> >  	       const struct path *root,
> > -	       char *buf, int buflen)
> > +	       char *buf, unsigned int buflen)
> >  {
> >  	DECLARE_BUFFER(b, buf, buflen);
> 
> I have questions about the quality of the analysis tool you're using.
> 
> struct prepend_buffer {
>         char *buf;
>         int len;
> };
> #define DECLARE_BUFFER(__name, __buf, __len) \
>         struct prepend_buffer __name = {.buf = __buf + __len, .len = __len}
> 
> Why is it not flagging the assignment of an unsigned int buflen to
> a signed int len?

Ah, I could not run the tool after I made this change.  I can change len
in prepend_buffer as well.

> > +char *__d_path(const struct path *, const struct path *, char *, unsigned int);
> > +char *d_absolute_path(const struct path *, char *, unsigned int);
> > +char *d_path(const struct path *, char *, unsigned int);
> > +char *dentry_path_raw(const struct dentry *, char *, unsigned int);
> > +char *dentry_path(const struct dentry *, char *, unsigned int);
> 
> While you're touching these declarations, please name the 'unsigned int'
> parameter.  I don't care about the others; they are obvious, but an
> unsigned int might be flags, a length, or a small grey walrus.

Sure, will respin this with both of those changes.  Thanks for the
review.

greg k-h