linux-kernel - Re: [PATCH v4 4/5] staging: vchiq: Make creation of vchiq cdev optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQAJLao8H1Hl5VVf@kroah.com>
Date:   Tue, 27 Jul 2021 15:25:01 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ojaswin Mujoo <ojaswin98@...il.com>
Cc:     nsaenz@...nel.org, stefan.wahren@...e.com,
        dan.carpenter@...cle.com, phil@...pberrypi.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/5] staging: vchiq: Make creation of vchiq cdev
 optional

On Wed, Jul 21, 2021 at 09:50:52PM +0530, Ojaswin Mujoo wrote:
> Before this commit, vchiq cdev (/dev/vchiq) was always created during
> platform initialization. Introduce a new Kconfig option
> CONFIG_VCHIQ_CDEV which determines if the cdev will be created or not.
> 
> Signed-off-by: Ojaswin Mujoo <ojaswin98@...il.com>
> ---
>  drivers/staging/vc04_services/Kconfig                  | 10 ++++++++++
>  drivers/staging/vc04_services/Makefile                 |  5 ++++-
>  .../vc04_services/interface/vchiq_arm/vchiq_arm.h      |  9 +++++++++
>  3 files changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig
> index 4b886293f198..63caa6818d37 100644
> --- a/drivers/staging/vc04_services/Kconfig
> +++ b/drivers/staging/vc04_services/Kconfig
> @@ -19,6 +19,16 @@ config BCM2835_VCHIQ
>  		Defaults to Y when the Broadcom Videocore services
>  		are included in the build, N otherwise.
>  
> +if BCM2835_VCHIQ
> +
> +config VCHIQ_CDEV
> +	bool "VCHIQ Character Driver"
> +	help
> +		Enable the creation of VCHIQ character driver to help
> +		communicate with the Videocore platform.

I'll take this, but this really should say more about what this really
is for.  Who needs this?  Why will I know if I want a character driver
interface?  What tools talk to this?

Or conversely, why would I want to turn this off?

Can you send a follow-on patch that makes this more descriptive?

thanks,

greg k-h