linux-kernel - Re: [PATCH v3 0/7] staging: rtl8188eu: replace driver with better version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c42ded8d-8027-eee3-c1c5-54e0736a1758@lwfinger.net>
Date:   Tue, 27 Jul 2021 09:13:09 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Phillip Potter <phil@...lpotter.co.uk>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-staging@...ts.linux.dev, Fabio Aiuto <fabioaiuto83@...il.com>
Subject: Re: [PATCH v3 0/7] staging: rtl8188eu: replace driver with better
 version

On 7/27/21 8:47 AM, Greg KH wrote:
> On Tue, Jul 27, 2021 at 02:25:34PM +0100, Phillip Potter wrote:
>> On Tue, 27 Jul 2021 at 14:06, Greg KH <gregkh@...uxfoundation.org> wrote:
>>>
>>> On Sat, Jul 24, 2021 at 01:10:48AM +0100, Phillip Potter wrote:
>>>> I had to break this patchset up a bit to get around the file size limits
>>>> on the mailing list, and also I removed the hostapd stuff which is
>>>> userspace related and therefore not required.
>>>>
>>>> The driver currently in staging is older and less functional than the
>>>> version on Larry Finger's GitHub account, based upon v4.1.4_6773.20130222.
>>>> This series of patches therefore:
>>>>
>>>> (1) Removes the current driver from staging.
>>>> (2) Imports the GitHub version mentioned above in its place.
>>>
>>> Let's do (2) first before worrying about (1), given that we can't get a
>>> version of (2) that actually builds yet :)
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Dear Greg,
>>
>> I'm confused - v3 patchset builds fine for me after applying in
>> sequence from 1 to 7?
> 
> Why does kbuild report problems?
> 
> Anyway, please let's just add the new driver in a new directory, get it
> building, and then we can remove the old one.  That way patches will
> continue to work and there's no confusion when backporting patches as
> the code bases are different.

I get no kbuild problems in the staging-next branch. I have no idea why the test 
robot is reporting errors.

Keeping the old rtl8188eu directory and builds will result in 3 drivers 
competing for the hardware including rtl8xxxu, rtl8188eu, and r8188eu.

Larry