linux-kernel - Re: [PATCH] drm/pl111: Remove unused including <linux/version.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ecafb6ba-ec4f-b98f-c07a-1b03a46a8b71@infradead.org>
Date:   Tue, 27 Jul 2021 07:29:14 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Cai Huoqing <caihuoqing@...du.com>, emma@...olt.net,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/pl111: Remove unused including <linux/version.h>

On 7/26/21 10:21 PM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

as reported by 'make versioncheck':

../drivers/gpu/drm/pl111/pl111_display.c: 14 linux/version.h not needed.
../drivers/gpu/drm/pl111/pl111_drv.c: 47 linux/version.h not needed.


> ---
>  drivers/gpu/drm/pl111/pl111_display.c | 1 -
>  drivers/gpu/drm/pl111/pl111_drv.c     | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index b5a8859739a2..443e3b932322 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -11,7 +11,6 @@
>  
>  #include <linux/clk.h>
>  #include <linux/delay.h>
> -#include <linux/version.h>
>  #include <linux/dma-buf.h>
>  #include <linux/of_graph.h>
>  
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index fa0a737e9dea..520301b405f1 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -44,7 +44,6 @@
>  #include <linux/of_reserved_mem.h>
>  #include <linux/shmem_fs.h>
>  #include <linux/slab.h>
> -#include <linux/version.h>
>  
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_bridge.h>
> 

thanks.
-- 
~Randy