linux-kernel - Re: [PATCH v2] platform/x86/intel: Move Intel PMT drivers to new subfolder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00527c09b0d4f22652f9cd5c2fde4e091df2d610.camel@linux.intel.com>
Date:   Tue, 27 Jul 2021 07:53:41 -0700
From:   "David E. Box" <david.e.box@...ux.intel.com>
To:     Joe Perches <joe@...ches.com>, hdegoede@...hat.com,
        mgross@...ux.intel.com, andriy.shevchenko@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86/intel: Move Intel PMT drivers to new
 subfolder

On Mon, 2021-07-26 at 20:36 -0700, Joe Perches wrote:
> On Mon, 2021-07-26 at 19:25 -0700, David E. Box wrote:
> > Move all Intel Platform Monitoring Technology drivers to
> > drivers/platform/x86/intel/pmt.
> []
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -9494,7 +9494,7 @@ INTEL PMT DRIVER
> >  M:     "David E. Box" <david.e.box@...ux.intel.com>
> >  S:     Maintained
> >  F:     drivers/mfd/intel_pmt.c
> > -F:     drivers/platform/x86/intel_pmt_*
> > +F:     drivers/platform/x86/intel/pmt/*
> 
> Unless you are suggesting you are not maintainer of any files
> in any subdirectories below this directory, you should not use
> a *
> 
> F:      drivers/platform/x86/intel/pmt/

Ack

> 
> > diff --git a/drivers/platform/x86/intel/Makefile
> > b/drivers/platform/x86/intel/Makefile
> []
> > @@ -7,3 +7,4 @@
> >  obj-$(CONFIG_INTEL_CHT_INT33FE)                += int33fe/
> >  obj-$(CONFIG_INTEL_SKL_INT3472)                += int3472/
> >  obj-$(CONFIG_INTEL_PMC_CORE)           += pmc/
> > +obj-y                                  += pmt/
> 
> This seems odd.  Perhaps:
> 
> obj-$(CONFIG_PMT_CLASS)                         += pmt/

This would work.

Thanks