linux-kernel - Re: [PATCH v2 1/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip banks per device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMhs-H_XktfW0PnK3yURS_bVBM10qws3iDp3Xgb602AZim0c=Q@mail.gmail.com>
Date:   Tue, 27 Jul 2021 17:06:56 +0200
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Gregory Fong <gregory.0xf0@...il.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        René van Dorst <opensource@...rst.com>,
        John Thomson <git@...nthomson.fastmail.com.au>,
        NeilBrown <neil@...wn.name>,
        Nicholas Mc Guire <hofrat@...dl.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] gpiolib: convert 'devprop_gpiochip_set_names' to
 support multiple gpiochip banks per device

On Tue, Jul 27, 2021 at 5:05 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Tue, Jul 27, 2021 at 5:48 PM Sergio Paracuellos
> <sergio.paracuellos@...il.com> wrote:
> >
> > The default gpiolib-of implementation does not work with the multiple
> > gpiochip banks per device structure used for example by the gpio-mt7621
> > and gpio-brcmstb drivers. To fix these kind of situations driver code
> > is forced to fill the names to avoid the gpiolib code to set names
> > repeated along the banks. Instead of continue with that antipattern
> > fix the gpiolib core function to get expected behaviour for every
> > single situation adding a field 'offset' in the gpiochip structure.
> > Doing in this way, we can assume this offset will be zero for normal
> > driver code where only one gpiochip bank per device is used but
> > can be set explicitly in those drivers that really need more than
> > one gpiochip.
>
> ...
>
> > +               dev_warn(&gdev->dev, "gpio-line-names too short (length %d) "
> > +                        "cannot map names for the gpiochip at offset %u\n",
>
> Reflow this that string literal will be on one line (it's fine to be
> over even 100).

Ah, ok. Will fix this and send v3.

Thanks,
    Sergio Paracuellos

>
> > +                        count, chip->offset);
>
> --
> With Best Regards,
> Andy Shevchenko