linux-kernel - Re: [PATCH net-next v3 06/31] phonet: use siocdevprivate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1745398.PdPXp2ZHHY@basile.remlab.net>
Date:   Tue, 27 Jul 2021 19:03:32 +0300
From:   Rémi Denis-Courmont <remi@...lab.net>
To:     netdev@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd@...db.de>,
        Remi Denis-Courmont <courmisch@...il.com>
Subject: Re: [PATCH net-next v3 06/31] phonet: use siocdevprivate

Le tiistaina 27. heinäkuuta 2021, 16.44.52 EEST Arnd Bergmann a écrit :
> From: Arnd Bergmann <arnd@...db.de>
> 
> phonet has a single private ioctl that is broken in compat
> mode on big-endian machines today because the data returned
> from it is never copied back to user space.
> 
> Move it over to the ndo_siocdevprivate callback, which also
> fixes the compat issue.
> 
> Cc: Remi Denis-Courmont <courmisch@...il.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Rémi Denis-Courmont <courmisch@...il.com>

-- 
This made me realise that the HSI/SSI device driver lacks the private IOCTL 
(but that's obivously not a problem of this series).

-- 
Rémi Denis-Courmont
http://www.remlab.net/