linux-kernel - Re: [PATCH] scsi: megaraid_mm: Fix end of loop tests for list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1k0lcqw8v.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 26 Jul 2021 23:20:11 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     kashyap.desai@...adcom.com
Cc:     Harshvardhan Jha <harshvardhan.jha@...cle.com>,
        sumit.saxena@...adcom.com, shivasharan.srikanteshwara@...adcom.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH] scsi: megaraid_mm: Fix end of loop tests for
 list_for_each_entry


Kashyap,

> The list_for_each_entry() iterator, "adapter" in this code, can never be
> NULL.  If we exit the loop without finding the correct  adapter then
> "adapter" points invalid memory that is an offset from the list head.
> This will eventually lead to memory corruption and presumably a kernel
> crash.

Please review. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering