linux-kernel - Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9902deed-021c-ad37-7fc7-f4279886c683@lwfinger.net>
Date:   Wed, 28 Jul 2021 13:41:15 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Phillip Potter <phil@...lpotter.co.uk>
Cc:     dan.carpenter@...cle.com, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, fabioaiuto83@...il.com,
        martin@...ser.cx
Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu
 driver

On 7/28/21 1:14 PM, Greg KH wrote:
> Hm, I thought this would be in better shape than it is.
> 
> Right now we have 107 .c and .h files in drivers/staging/rtl8188eu/ that
> come to a total of 44597 lines.
> 
> So we are taking double the size here?
> 
> I'm all for putting a "better" driver in here, but this feels odd to
> me...  Is there major new functionality here that is not in the existing
> driver to justify this?
> 
> Ok, let's see how this goes, I'll give it a few weeks to see how much
> can easily be fixed up to hopefully get back to at least close the
> existing driver size...

The major new functionality is that the new one uses cfg80211, whereas the old 
one uses the WEXT calls.

It really is an improvement. It just needs a severe cleanup.

I warned you that this code was rough. It took me several weeks to get the old 
one "ready" for staging. I never devoted that effort to the new one, and you 
wanted it in a place where multiple authors could improve it.

Larry