linux-kernel - Re: [PATCH v2 00/10] i2c: xiic: Add features, bug fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d70b569d-a0e3-81b0-a553-ed88423924f7@denx.de>
Date:   Wed, 28 Jul 2021 20:47:26 +0200
From:   Marek Vasut <marex@...x.de>
To:     Raviteja Narayanam <rna@...inx.com>,
        Michal Simek <michals@...inx.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>, "joe@...ches.com" <joe@...ches.com>
Subject: Re: [PATCH v2 00/10] i2c: xiic: Add features, bug fixes.

On 7/28/21 12:11 PM, Raviteja Narayanam wrote:
[...]

>>>>>>> I have tested this again on our boards with eeprom and other
>>>>>>> sensors, this
>>>>>> is working fine for us.
>>>>>>
>>>>>> Can you share details of how those tests were performed ?
>>>>>
>>>>> Stress test - 1:
>>>>> Heavy ethernet traffic running in the background.
>>>>> I2c commands script (like below) running. We can see visible stutter
>>>>> in the
>>>> output as expected, but nothing failed.
>>>>>
>>>>> i=0
>>>>> while [ 1 ]
>>>>> do
>>>>> 		i2ctransfer -y -f 2 w1@...4 0X00 r31@...4
>>>>> 		i2ctransfer -y -f 2 w1@...4 0X00 r32@...4
>>>>> 		i2ctransfer -y -f 2 w1@...4 0X00 r255@...4
>>>>> 		i2ctransfer -y -f 2 w1@...4 0X00 r273@...4
>>>>>                                 i2ctransfer -y -f 2 w1@...4 0X00
>>>>> r1@...4
>>>>
>>>> Could it be that you never see the problem because you always talk to
>>>> one single device ?
>>>
>>> There are transfers to other devices as well.
>>
>> The above test only accesses device at address 0x54, right ?
> 
> Above code is just one part.
> We are doing read/writes to all devices present on this board https://www.xilinx.com/support/documentation/boards_and_kits/zcu102/ug1182-zcu102-eval-bd.pdf

Can you share details of how those tests were performed ?

>>> Our board has multiple power monitors, eeprom and other misc devices
>>> that are accessed through the same driver and are working fine.
>>
>> That does not seem to be what the test above does .
>>
>>>> Do you also test writes which are not 1 byte long ?
>>>>
>>>
>>> Yes, like for eeprom 1 page (16 bytes)  is written.
>>
>> I suspect the atmel mxt does much longer writes, try 255 bytes or so.
> 
> Ok, I will do longer writes (in the range of 255) on supported slave devices.

Thank you