linux-kernel - Re: [PATCH 2/2] staging: vchiq: Add details to $CONFIG_VCHIQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210728200039.GA17046@ojas>
Date:   Thu, 29 Jul 2021 01:30:39 +0530
From:   Ojaswin Mujoo <ojaswin98@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     nsaenz@...nel.org, stefan.wahren@...e.com,
        dan.carpenter@...cle.com, phil@...pberrypi.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: vchiq: Add details to $CONFIG_VCHIQ_CDEV
 help text

On Wed, Jul 28, 2021 at 08:46:51PM +0200, Greg KH wrote:
> On Thu, Jul 29, 2021 at 12:07:17AM +0530, Ojaswin Mujoo wrote:
> > Add some details to the Kconfig definition of $CONFIG_VCHIQ_CDEV to help
> > make the motive behind it a bit more clear.
> > 
> > Signed-off-by: Ojaswin Mujoo <ojaswin98@...il.com>
> > ---
> >  drivers/staging/vc04_services/Kconfig | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig
> > index 2b70c37cdd09..cb02d8a4cb74 100644
> > --- a/drivers/staging/vc04_services/Kconfig
> > +++ b/drivers/staging/vc04_services/Kconfig
> > @@ -25,8 +25,12 @@ config VCHIQ_CDEV
> >  	bool "VCHIQ Character Driver"
> >  	default y
> >  	help
> > -		Enable the creation of VCHIQ character driver to help
> > -		communicate with the Videocore platform.
> > +		Enable the creation of VCHIQ character driver to help communicate
> > +		with the VideoCore platform. The cdev exposes ioctls used by
> > +		userspace libraries and testing tools to interact with VideoCore.
> > +		This can be set to 'N' if the VideoCore communication is not needed
> > +		by userspace but only by other kernel modules (like bcm2835-audio).
> > +		If not sure, set this to 'Y'.
> 
> I still do not understand if I need this driver or not, and I have this
> hardware!  What functionality does this driver accomplish?  What is
> VideoCore?
Hey Greg,

I believe I can add this under the CONFIG_BCM2835_VCHIQ config option,
as that enables the core driver that implements the functions to
communicate with VideoCore platform? 

This config option merely adds a cdev which exposes the the core
driver's functionality to userspace. 

Regards,
Ojaswin
> 
> thanks,
> 
> greg k-h