[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3382bb94-0cf1-52eb-1b97-69b4536f4874@nvidia.com>
Date: Wed, 28 Jul 2021 17:01:42 -0500
From: Shanker R Donthineni <sdonthineni@...dia.com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: Amey Narkhede <ameynarkhede03@...il.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
<alex.williamson@...hat.com>,
Raphael Norwitz <raphael.norwitz@...anix.com>,
<linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<kw@...ux.com>, Sinan Kaya <okaya@...nel.org>,
Len Brown <lenb@...nel.org>,
"Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v10 2/8] PCI: Add new array for keeping track of ordering
of reset methods
On 7/28/21 3:25 PM, Bjorn Helgaas wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, Jul 28, 2021 at 01:31:19PM -0500, Shanker R Donthineni wrote:
>> Hi Bjorn,
>>
>> On 7/27/21 5:59 PM, Bjorn Helgaas wrote:
>>>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
>>>> index fefa6d7b3..42440cb10 100644
>>>> --- a/drivers/pci/pci.c
>>>> +++ b/drivers/pci/pci.c
>>>> @@ -72,6 +72,14 @@ static void pci_dev_d3_sleep(struct pci_dev *dev)
>>>> msleep(delay);
>>>> }
>>>>
>>>> +int pci_reset_supported(struct pci_dev *dev)
>>>> +{
>>>> + u8 null_reset_methods[PCI_NUM_RESET_METHODS] = { 0 };
>>>> +
>>>> + return memcmp(null_reset_methods,
>>>> + dev->reset_methods, sizeof(null_reset_methods));
>>> I think "return dev->reset_methods[0] != 0;" is sufficient, isn't it?
>>>
>> Agree with you, it simplifies code logic and can be moved to
>> "include/linux/pci.h" with inline definition. Can we change return
>> type to 'bool' instead of 'int' ?
> Does it need to be exported to drivers? Looks like it's only used
> inside drivers/pci/, so it shouldn't be in include/linux/pci.h.
Yes, you're right can be moved to driver/pci/pci.h.
> Making it bool is fine with me.
>
>> static inline bool pci_reset_supported(struct pci_dev *dev)
>> {
>> return !!dev->reset_methods[0];
>> }
>>
Powered by blists - more mailing lists