linux-kernel - Re: [PATCH v2] PCI/AER: Change to use helper pcie_aer_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jul 2021 17:08:42 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Xiaofei Tan <tanxiaofei@...wei.com>
Cc:     bhelgaas@...gle.com, sathyanarayanan.kuppuswamy@...ux.intel.com,
        sean.v.kelley@...el.com, Jonathan.Cameron@...wei.com,
        refactormyself@...il.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH v2] PCI/AER: Change to use helper pcie_aer_is_native() in
 some places

On Fri, Feb 05, 2021 at 10:04:08AM +0800, Xiaofei Tan wrote:
> Use helper function pcie_aer_is_native() in some places to keep
> the code tidy. No function changes.
> 
> Signed-off-by: Xiaofei Tan <tanxiaofei@...wei.com>
> Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>
> 
> ---
> Changes from v1 to v2:
> - Add the fix suggested by Krzysztof.
> ---
>  drivers/pci/pcie/aer.c          | 4 ++--
>  drivers/pci/pcie/err.c          | 2 +-
>  drivers/pci/pcie/portdrv_core.c | 3 +--
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 77b0f2c..03212d0 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -1397,7 +1397,7 @@ static pci_ers_result_t aer_root_reset(struct pci_dev *dev)
>  	 */
>  	aer = root ? root->aer_cap : 0;
>  
> -	if ((host->native_aer || pcie_ports_native) && aer) {
> +	if (pcie_aer_is_native(dev) && aer) {

Are we guaranteed that "dev" has an AER capability?  I guess so,
because the function comment says "dev" is a Root Port, an RCEC, or an
RCiEP.  I *guess* that we only get here if "dev" has an AER
capability?  I wish this were a little more obvious from the code.

If "dev" does not have AER, we previously cleared
ROOT_PORT_INTR_ON_MESG_MASK, but after this patch we won't.

  pcie_aer_is_native(struct pci_dev *dev)
  {
    struct pci_host_bridge *host = pci_find_host_bridge(dev->bus);

    if (!dev->aer_cap)
      return 0;

    return pcie_ports_native || host->native_aer;
  }

If we do decide this patch is correct, I think we can drop the "host",
which is no longer used in this function.

>  		/* Disable Root's interrupt in response to error messages */
>  		pci_read_config_dword(root, aer + PCI_ERR_ROOT_COMMAND, &reg32);
>  		reg32 &= ~ROOT_PORT_INTR_ON_MESG_MASK;
> @@ -1417,7 +1417,7 @@ static pci_ers_result_t aer_root_reset(struct pci_dev *dev)
>  		pci_info(dev, "Root Port link has been reset (%d)\n", rc);
>  	}
>  
> -	if ((host->native_aer || pcie_ports_native) && aer) {
> +	if (pcie_aer_is_native(dev) && aer) {
>  		/* Clear Root Error Status */
>  		pci_read_config_dword(root, aer + PCI_ERR_ROOT_STATUS, &reg32);
>  		pci_write_config_dword(root, aer + PCI_ERR_ROOT_STATUS, reg32);
> diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c
> index 510f31f..1d6cfb9 100644
> --- a/drivers/pci/pcie/err.c
> +++ b/drivers/pci/pcie/err.c
> @@ -237,7 +237,7 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
>  	 * this status.  In that case, the signaling device may not even be
>  	 * visible to the OS.
>  	 */
> -	if (host->native_aer || pcie_ports_native) {
> +	if (pcie_aer_is_native(dev)) {
>  		pcie_clear_device_status(bridge);

Is it guaranteed that "dev" has an AER capability here?  Again, it's
not obvious to me that it must; this path is used from DPC and EDR as
well as AER.

If it's not guaranteed, assume "dev" is a PCIe device with no AER
capability.  It still has a Device Status register, and previously we
called pcie_clear_device_status() to clear it.

Now we won't clear it.

>  		pci_aer_clear_nonfatal_status(bridge);
>  	}
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index e1fed664..3b3743e 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -221,8 +221,7 @@ static int get_port_device_capability(struct pci_dev *dev)
>  	}
>  
>  #ifdef CONFIG_PCIEAER
> -	if (dev->aer_cap && pci_aer_available() &&
> -	    (pcie_ports_native || host->native_aer)) {
> +	if (pci_aer_available() && pcie_aer_is_native(dev)) {
>  		services |= PCIE_PORT_SERVICE_AER;
>  
>  		/*
> -- 
> 2.8.1
>