linux-kernel - Re: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <141602a3-ef61-01f0-4a3c-69f8e7012fcd@intel.com>
Date:   Wed, 28 Jul 2021 15:19:46 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Tony Luck <tony.luck@...el.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Jarkko Sakkinen <jarkko@...nel.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC
 pages

On 7/28/21 1:46 PM, Tony Luck wrote:
> Export a function sgx_is_epc_page() that simply reports whether an
> address is an EPC page for use elsewhere in the kernel.

It would be really nice to mention why this needs to be exported to
modules.  I assume it's the error injection driver or something that can
be built as a module, but this export was a surprise when I saw it.

It's probably also worth noting that this is a sloooooooow
implementation compared to the core VM code that does something
analogous: pfn_to_page().  It's fine for error handling, but we should
probably have a comment to this effect so that more liberal use doesn't
creep in anywhere.