linux-kernel - Re: [PATCH] lib: use of kunit in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jul 2021 12:46:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     José Aquiles Guedes de Rezende 
        <jjoseaquiless@...il.com>, Jiri Pirko <jiri@...dia.com>
Cc:     clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        brendanhiggins@...gle.com, dlatypov@...gle.com,
        davidgow@...gle.com, linux-kselftest@...r.kernel.org,
        ~lkcamp/patches@...ts.sr.ht,
        José Aquiles Guedes de Rezende 
        <jjoseaquiless@...il.com>,
        Matheus Henrique de Souza Silva 
        <matheushenriquedesouzasilva@...tonmail.com>
Subject: Re: [PATCH] lib: use of kunit in test_parman.c

Hi "José,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ipvs/master]
[also build test ERROR on linux/master linus/master v5.14-rc3 next-20210727]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jos-Aquiles-Guedes-de-Rezende/lib-use-of-kunit-in-test_parman-c/20210728-070506
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: powerpc64-buildonly-randconfig-r006-20210727 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c49df15c278857adecd12db6bb1cdc96885f7079)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://github.com/0day-ci/linux/commit/28790f5c89e89dc96adf7bd4c748ddd505a52391
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jos-Aquiles-Guedes-de-Rezende/lib-use-of-kunit-in-test_parman-c/20210728-070506
        git checkout 28790f5c89e89dc96adf7bd4c748ddd505a52391
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> lib/test_parman.c:96:32: error: no member named 'kunit_test' in 'struct task_struct'
           struct kunit *test = current->kunit_test;
                                ~~~~~~~  ^
   1 error generated.


vim +96 lib/test_parman.c

    93	
    94	static int test_parman_resize(void *priv, unsigned long new_count)
    95	{
  > 96		struct kunit *test = current->kunit_test;
    97		struct test_parman *test_parman = priv;
    98		struct test_parman_item **prio_array;
    99		unsigned long old_count;
   100	
   101		prio_array = krealloc(test_parman->prio_array,
   102				      ITEM_PTRS_SIZE(new_count), GFP_KERNEL);
   103		KUNIT_EXPECT_NOT_ERR_OR_NULL(test, prio_array);
   104		if (new_count == 0)
   105			return 0;
   106		if (!prio_array)
   107			return -ENOMEM;
   108		old_count = test_parman->prio_array_limit;
   109		if (new_count > old_count)
   110			memset(&prio_array[old_count], 0,
   111			       ITEM_PTRS_SIZE(new_count - old_count));
   112		test_parman->prio_array = prio_array;
   113		test_parman->prio_array_limit = new_count;
   114		return 0;
   115	}
   116	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (41642 bytes)