linux-kernel - Re: [PATCH] fault-inject: Declare the second argument of setup_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9afbc59c-f745-03c1-c74d-264a7180ec87@acm.org>
Date:   Wed, 28 Jul 2021 16:05:30 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Akinobu Mita <akinobu.mita@...il.com>
Cc:     linux-kernel@...r.kernel.org, Jaegeuk Kim <jaegeuk@...nel.org>
Subject: Re: [PATCH] fault-inject: Declare the second argument of
 setup_fault_attr() const

On 7/8/21 11:34 AM, Bart Van Assche wrote:
> This patch makes it possible to pass a const char * argument to
> setup_fault_attr() without having to cast away constness.
> 
> Cc: Akinobu Mita <akinobu.mita@...il.com>
> Signed-off-by: Bart Van Assche <bvanassche@....org>
> ---
>   include/linux/fault-inject.h | 2 +-
>   lib/fault-inject.c           | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h
> index e525f6957c49..afc649f0102b 100644
> --- a/include/linux/fault-inject.h
> +++ b/include/linux/fault-inject.h
> @@ -42,7 +42,7 @@ struct fault_attr {
>   	}
>   
>   #define DECLARE_FAULT_ATTR(name) struct fault_attr name = FAULT_ATTR_INITIALIZER
> -int setup_fault_attr(struct fault_attr *attr, char *str);
> +int setup_fault_attr(struct fault_attr *attr, const char *str);
>   bool should_fail(struct fault_attr *attr, ssize_t size);
>   
>   #ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index ce12621b4275..45520151b32d 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -15,7 +15,7 @@
>    * setup_fault_attr() is a helper function for various __setup handlers, so it
>    * returns 0 on error, because that is what __setup handlers do.
>    */
> -int setup_fault_attr(struct fault_attr *attr, char *str)
> +int setup_fault_attr(struct fault_attr *attr, const char *str)
>   {
>   	unsigned long probability;
>   	unsigned long interval;

Hi Akinobu,

Did I send this patch to the right person?

Thanks,

Bart.